-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Changes ACL permission setting hints #3566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The default behavior of setfacl is to recalculate the ACL mask entry, unless a mask entry was explicitly given.
Hey Michele! Can you explain this a bit more? I'll admit that ACL is not my strongpoint, and I can read the Thanks! |
I think the explanation falls into these paragraphs:
so in a way trying to avoid automatic adjustment of the effective permissions of the mask. But yeah we need an expert opinion. |
If the main goal of documentation ACL hints is to prepare directories to work in any condition, it should be better to have ACL winning on mask options. |
yes I agree, we should merge this |
@weaverryan an example of software that would write umasks while running is sqlite, so it could happen to have resources covered by an umask into the cache directory. |
Using everyday a Debian derivate distro instead of Appleish products mwould make ACL problems more evident. |
Thanks guys! I'll admit, I still don't really understand what this does, but I'm also pretty sure that's due to my lack of knowledge about the ACL's and masks themselves (but you seem to understand well). Anways, thanks for the change! :) |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #3566). Discussion ---------- Changes ACL permission setting hints The default behavior of setfacl is to recalculate the ACL mask entry, unless a mask entry was explicitly given. Commits ------- 4480eff Changes ACL permission setting hints
Thanks to you for the effort on documentation! |
Hi, just tried the new way on a Linux Mint 16 sytem using the -n parameter. In my system leads to an effective: r-x for both, www-data ($APACHEUSER) and the 'whoami'. I deleted all acl rights but the standard for owner, group, other and retried. Always lead to #effective: r-x. As soon as i deleted the acl rights and used it without the -n parameter it worked like a charm. So there seem to be differences in the systems maybe? When i used the commands via C&P before, it always worked for me on Debian 6/7 and Ubuntu 12.04 LTS. Maybe there should be an additional hint? EDIT (finally after serveral c&p errors): sr972@main /var/www $ setfacl -bk app/cache
sr972@main /var/www $ getfacl app/cache
# file: app/cache
# owner: sr972
# group: sr972
user::rwx
group::r-x
other::r-x
sr972@main /var/www $ sudo setfacl -Rn -m u:"$APACHEUSER":rwX -m u:`whoami`:rwX app/cache app/logs
sr972@main /var/www $ sudo setfacl -dRn -m u:"$APACHEUSER":rwX -m u:`whoami`:rwX app/cache app/logs
sr972@main /var/www $ getfacl app/cache
# file: app/cache
# owner: sr972
# group: sr972
user::rwx
user:www-data:rwx #effective:r-x
user:sr972:rwx #effective:r-x
group::r-x
mask::r-x
other::r-x
default:user::rwx
default:user:www-data:rwx #effective:r-x
default:user:sr972:rwx #effective:r-x
default:group::r-x
default:mask::r-x
default:other::r-x
sr972@main /var/www $ setfacl -bk app/cache
sr972@main /var/www $ getfacl app/cache
# file: app/cache
# owner: sr972
# group: sr972
user::rwx
group::r-x
other::r-x
sr972@main /var/www $ sudo setfacl -R -m u:"$APACHEUSER":rwX -m u:`whoami`:rwX app/cache app/logs
sr972@main /var/www $ sudo setfacl -dR -m u:"$APACHEUSER":rwX -m u:`whoami`:rwX app/cache app/logs
sr972@main /var/www $ getfacl app/cache
# file: app/cache
# owner: sr972
# group: sr972
user::rwx
user:www-data:rwx
user:sr972:rwx
group::r-x
mask::rwx
other::r-x
default:user::rwx
default:user:www-data:rwx
default:user:sr972:rwx
default:group::r-x
default:mask::rwx
default:other::r-x |
Wich version of ACL are you using? |
@sr972 I think you should make another pull request and move the discussion on that one! |
Yes @sr972 - can you open up a pull request with the changes and details? The truth is, this command seems to be very difficult to get right, and it's very very technical. So, if it's not working for you, it's likely not working for others, and I'd love to have a PR where we can discuss it (so it doesn't get lost!). Thanks! |
See #3712 - there is indeed now a problem with this command |
Exactly for me on Linux, setfacl works as usual with -dR and -d option only... without -n option, because that cause rights problems. |
The default behavior of setfacl is to recalculate the ACL mask entry, unless a mask entry was explicitly given.